Hooray! Thanks man. I took a few shots at it but always came up short. 

Could somebody explain how to properly test this? 

I think just get a map that takes a long time to VIS and stop/start it repeatedly. 

I tried gmsp3tw and it worked very well. 

But can you get a failure with the old version? The old version worked most of the time - until it didn't. :) 

I set the -savetime to 10 and interrupted it a lot. Got the error in return at the end. 

I set the -savetime to 10 and interrupted it a lot. Got the error in return at the end. 

Release the src, please. 

I wanted to wait for more feedback - or at least for no negative results. I will send the patch to Spirit later today or tomorrow when I have access to the machine again. I hope he can review it and decide whether it qualifies for the bounty or not :-) 

 

http://www.quaddicted.com/quaddictedcom/first-bounty-claimed-multi-thread-vis-bug-fixed/ 

http://www.quaddicted.com/tools/wvis_20100117.7z
sorry, zip would not work 

Call for testing! Please re-download the test version from my location above. Its a newer version which should be more efficient and hopefully also has the bug fixed. 

When I use -nosave, I don't get %/time interval updates from the "full" part of the vis process. 

Updated the .zip file. I think this bug was also in the original version?

Now there is also the chance that if you have a corrupted .vis file that it gets repaired when it gets loaded. 

It indeed loads my corrupted state file and seems to be continuing the process normally. 

Is this the 'idle' or the 'reset' version? 

This should be the 'right' version: No thread synchronization is done. Instead undone portals are marked as such instead upon saving.

If no bugs are found this should become the recommended version.

In the end the fix could probably be done by changing one line. But I think its ok to fix some other things while we are at it. 

Nice work, tuna! 

I'm currently testing it on my coag map. The ultimate goal would be to get all portals done except for the long one, thus making the PVS data as complete as possible. Problem is that I can't tell what's going on as the -verbose display isn't as clear as in single-thread mode. Or dunno.. 

Hm. Not sure what the verbose messages are supposed to output. In theory just keep an eye on the CPU usage. When the "Full" Vis step is only using one core you are there.. Might be difficult to spot when you are on a single core CPU. When the task manager displays the threads per process you might keep an eye on them.. 

fresh WVIS build: http://www.quaddicted.com/tools/wvis_20100119.7z 

Please include the source with the (final?) build - better than refering to several authors and versions.

As for my vis experiment, it really seems to work as intended. I still need to test the final result in Quake to check for HOMs, but it looks good so far. 

Great news. Up to now I think that my link contains the latest version and also includes the patch. I asked Spirit to update his links to avoid people loading the older version.

In general someone who is going to maintain the application should take care of packaging and updating the relevant links.. .. Willem? ;-) 

I dunno man, I'm going to be really busy this year with work. I'd rather you just throw the source code and binary (with an updated filename/version number) onto Quaketastic and let the community sort it out. :) It's just an EXE after all...

Put it all in "tools/windows/misc" preferably, to keep it all clean.