#705 posted by Baker on 2016/11/16 23:56:58
I think the only way we can know is by asking people to test sv_gameplayfix_setmodelrealbox 0 (Quake original).
Arcane Dimensions works in DP and is tested in DP and DP uses sv_gameplayfix_setmodelrealbox 0 (Quake original) and thus far no one has *seemed* to nothing anything.
/But yeah, I'm very afraid of sv_gameplayfix_setmodelrealbox 0 since nearly all single player releases have targeted that.
You'll like my source code on that, it's basically a 2 liner.
#706 posted by Baker on 2016/11/16 23:58:17
(*) "single player releases have targeted FitzQuake in the last 10 years."
#707 posted by metlslime
on 2016/11/17 00:52:47
I never realized setmodel sets the size as a side effect and that some mods rely on that.
Sounds like the fix is to set a minimum (or just force) size of 32^3 in PF_setmodel. I guess this could introduce PVS culling bugs, but only in mods that don't call setsize afterwards? And anyway culling bugs are not as bad as gameplay functionality bugs.
#708 posted by mh on 2016/11/17 01:12:29
Quake 2! Quake 2! Quake 2! Quake 2!
Seriously, Quake 2 has the fix for this. It has the correct +/- 16 for the server-side stuff, and it culls small/large models correctly for the client-side stuff.
There's really no need for this discussion. Grab the Quake 2 code (https://github.com/id-Software/Quake-2/blob/master/ref_gl/gl_mesh.c#L370), adapt it for the Quake differences, and all of these problems Just Go Away.
#709 posted by Baker on 2016/11/17 01:38:20
@mh -- you 100% this is only about culling?
What does setmodelsize do? What does QuakeC do with the mins/maxs?
Is it ever used for physics?
Spike says has Q-Rally has a *physics* issue with the FitzQuake way.
/My somewhat limited QuakeC internals is why I ask
#710 posted by Baker on 2016/11/17 01:39:49
If QRally has a physics issues with the FitzQuake way.
How do we know that there aren't single player releases designed for FitzQuake that will show physics problems if this is reversed?
Probably Not A Problem -- Here Is Why ...
#711 posted by Baker on 2016/11/17 01:46:53
Very few single player authors do QuakeC.
Enhanced GLQuake was often used before FitzQuake 0.85 so releases from 2009 and earlier should be safe.
Preach, Tronyn, metslime, necros are among the group. I would presume that they are sticklers for setmodel and then setsize. Most of the others are multi-engine types.
Sock is also targeting DarkPlaces.
Until Preach doesn't setmodel in mapobject_custom in Quoth, using the original Quake box should be fine.
#712 posted by Mugwump
on 2016/11/17 03:06:15
Arcane Dimensions works in DP and is tested in DP and DP uses sv_gameplayfix_setmodelrealbox 0
DP defaults this cvar to 0 but experienced DP users set it back to 1 for compatibility with some custom maps.
#713 posted by Baker on 2016/11/17 03:26:05
Do you know the name of any particular map that it is known to make a difference?
#714 posted by Mugwump
on 2016/11/17 06:36:38
Well, before I set the gameplay fixes to 1 there were several maps in which I encountered bugs with pickups stuck in walls or missing altogether. I don't remember which maps specifically, except Solarfall: at the beginning of the map, turn right then left and you arrive in a room with a green armor pickup which was missing when I first played it. Though I suspect this particular issue might be fixed with sv_gameplayfix_droptofloorstartsolid 1, not setmodelrealbox.
#715 posted by QUAKEULUS on 2019/04/26 22:16:22
Similar problem with latest darkplaces in VR on android port.
Set gl_nopartialtextureupdates 1 to fix